Fix race condition in IORef backend#55
Open
konsumlamm wants to merge 1 commit intoHeinrichApfelmus:masterfrom
Open
Fix race condition in IORef backend#55konsumlamm wants to merge 1 commit intoHeinrichApfelmus:masterfrom
konsumlamm wants to merge 1 commit intoHeinrichApfelmus:masterfrom
Conversation
Owner
|
Thank you! Sorry for the delay. I like this, but this is I think the point where I should add some unit / property tests to the package. It's worth testing that the race condition is indeed gone. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should fix the race condition in the IORef backend. As far as I can tell, the race condition can only appear if the same
Keyis used in multipleVaults. By adding anMVar ()to theKey, we can ensure that only one thread accesses the storedIORefat a time.